feat: use overrides for connection settings #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.1.x #670 +/- ##
============================================
- Coverage 80.93% 80.82% -0.11%
- Complexity 495 516 +21
============================================
Files 73 73
Lines 1631 1622 -9
============================================
- Hits 1320 1311 -9
Misses 311 311 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keithbrink
force-pushed
the
use-overrides-for-connection-settings
branch
from
805f9a1 to
fa49493
Compare
|
I believe the test failures here are unrelated to these changes and require the test suite to be fixed on 3.1.x. |
keithbrink
force-pushed
the
use-overrides-for-connection-settings
branch
from
5e36050 to
61bc21b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added the
application_namesetting to our database configuration, which is supported by Laravel but was not passed into Doctrine by this package.I'm proposing that instead of specifying the exact set of keys passed to Doctrine, the package instead overrides the required ones and passes along the remaining array as is.