[0.x] Add timeout parameter to Agent contract#412
Merged
taylorotwell merged 1 commit intolaravel:0.xfrom Apr 21, 2026
Merged
Conversation
pushpak1300
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
timeoutparameter toAgentcontractThe
Promptabletrait already accepts an optional?int $timeoutparameter onprompt()andstream(), but theAgentcontract does not declare it. This causes IDE and static analysis warnings (e.g. PHPStanargument.named) when calling->prompt(..., timeout: 120)on anAgent-typed variable, since the contract signature doesn't include the parameter.Changes
?int $timeout = nulltoAgent::prompt()andAgent::stream()insrc/Contracts/Agent.php.Why
The
Promptabletrait (used by all concrete agents) already supportstimeouton both methods and passes it through toAgentPrompt. The contract simply didn't reflect this, creating a mismatch between the interface and its implementation.Impact
nulldefault.AgentFakeTestalready exercisetimeout:as a named argument on bothprompt()andstream().