Allow tools to declare their name dynamically#420
Open
seankndy wants to merge 1 commit intolaravel:0.xfrom
Open
Allow tools to declare their name dynamically#420seankndy wants to merge 1 commit intolaravel:0.xfrom
seankndy wants to merge 1 commit intolaravel:0.xfrom
Conversation
Gateways currently emit `class_basename($tool)` as the name sent to providers, and `InvokesTools::findTool` looks tools up by the same basename. Adapter-style tools (a single class that dispatches to many distinct targets per instance) all collapse to the same basename, so providers see duplicate names and cannot route calls correctly. Add a shared `ResolvesToolName` trait that honors an optional public `name()` method on the tool, falling back to `class_basename` when absent. The existing Prism gateway already used this pattern inline; native gateways now follow suit via the shared helper. Covered gateways: Anthropic, AzureOpenAi, DeepSeek, Gemini, Groq, Mistral, Ollama, OpenAi, OpenRouter, Xai, plus the shared `InvokesTools::findTool` lookup.
Contributor
|
This fixes the exact issue we ran into on our side. We have an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateways currently emit
class_basename($tool)as the name sent to providers, andInvokesTools::findToollooks tools up by the same basename. Adapter-style tools (a single class that dispatches to many distinct targets per instance) all collapse to the same basename, so providers see duplicate names and cannot route calls correctly.Add a shared
ResolvesToolNametrait that honors an optional publicname()method on the tool, falling back toclass_basenamewhen absent. The existing Prism gateway already used this pattern; native gateways now follow suit via the shared helper.Covered gateways: Anthropic, AzureOpenAi, DeepSeek, Gemini, Groq, Mistral, Ollama, OpenAi, OpenRouter, Xai, plus the shared
InvokesTools::findToollookup.Dynamic tool use-case example: