Use detected MIME types for OpenAI image attachments#433
Open
dhrupo wants to merge 1 commit intolaravel:0.xfrom
Open
Use detected MIME types for OpenAI image attachments#433dhrupo wants to merge 1 commit intolaravel:0.xfrom
dhrupo wants to merge 1 commit intolaravel:0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix OpenAI image attachment mapping for local and stored image files.
Problem
Files\Image::fromPath()could produce an invalid OpenAI image data URL because the OpenAI attachment mapper used the raw image MIME property instead of the file's detected MIME type. When the MIME property was unset, requests could be sent asdata:;base64,..., which OpenAI rejects with a 400 error.Fixes #417
Solution
Updated the OpenAI attachment mapper to use
mimeType()for local and stored image attachments, while preserving the existingimage/pngfallback when MIME detection is unavailable.Tests
Added regression tests covering:
.jpgimages mapped asdata:image/jpeg;base64,....jpgimages mapped asdata:image/jpeg;base64,...