Add a prettier for format
#59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnylea
reviewed
Mar 10, 2025
| @@ -1,273 +1,810 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="{{ str_replace('_', '-', app()->getLocale()) }}"> | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <meta charset="utf-8" /> | |||
There was a problem hiding this comment.
Can we figure out how to prevent the formatter from adding /> to single tags like this.
tnylea
requested changes
Mar 10, 2025
Rattone
reviewed
Mar 10, 2025
| @@ -9,7 +9,8 @@ | |||
| @custom-variant dark (&:where(.dark, .dark *)); | |||
|
|
|||
| @theme { | |||
| --font-sans: 'Instrument Sans', ui-sans-serif, system-ui, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'; | |||
| --font-sans: | |||
| 'Instrument Sans', ui-sans-serif, system-ui, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'; | |||
| autocomplete="email" | ||
| placeholder="[email protected]" | ||
| /> | ||
| <flux:input wire:model="email" :label="__('Email address')" type="email" required autocomplete="email" placeholder="[email protected]" /> |
There was a problem hiding this comment.
for elements with many attributes is it not better to go on multiple lines? is there not a limit of characters per line?
|
@michaelnabil230, let me know if you can address the concerns above and we can move forward with this PR. Really appreciate it 👏 |
tnylea
added
Pending Closure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding prettier to format the frontend.