Add RTL support #66
Open
Add RTL support #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, we've just merged RTL support into Flux livewire/flux#1340 and it should be in the next release. @3adeling has been helping us test it out 🙏 |
|
Excellent! Thanks @3adeling. It looks like RTL support for Flux has been merge in. Do we need to update the Flux dependency to take advantage of this? Let me know. Other then that, everything looks good 👍 |
|
@tnylea we haven't tagged the release yet, but can let you know once we have. I'd suggest bumping the dependency once that is done 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will prepare the Livewire starter kit for RTL support. Once Flux RTL support is released, the Livewire kit will automatically support it. The current changes will not impact the LTR styling and will only be applied when
dir="rtl"is set in all layouts.This PR also includes an update to the welcome.blade.php view to support RTL.