refactor: use type over interface for TS type definitions #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasweiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everybody!
This PR changes all type definitions from
interfacetotype.Using types over interfaces is very commen in the TS community, see e.g. https://www.totaltypescript.com/type-vs-interface-which-should-you-use#default-to-type-not-interface.
It would also allow for adding typechecking to the CI/CD workflows (without the need of adapting the exported types in Inertia itself). Some of the interfaces currently do not pass type checks and have been swapped by me in #31 or @christophstockinger in #37.
I'd definitely prefer types over interfaces, although that might also be a bit of personal preference. Let me know what you think! 😁