Reopen: Fix user reactivity in Navbar and improve password focus handling (prev. PR #54) #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2025
Contributor
|
Thanks @chabdulrahmn for the detailed PR and the visuals. I just tested your branch out on my end and it works great. Thanks again for the PR 👏 |
- Switched `user` from a static variable to a computed property to enable reactivity. This ensures updated user data (e.g. after profile update) is reflected in the NavBar without requiring a full page refresh. - Updated prop binding syntax from `:user="user"` to shorthand `:user`.
- Removed `passwordInput` ref and reliance on `$el` to access the input field inside the `Input` component. - Fixed `TypeError` caused by calling `focus()` on the component instance. - Now focusing the password input via `formElement.password` in the form's submit error handler. - Used `nextTick` to ensure the DOM is updated before focusing. - This approach is cleaner, avoids reliance on component internals, and works reliably with shadcn-vue components.
Author
|
✅ Conflicts have been resolved. This pull request is now ready to be merged. Please review and proceed with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refreshed version of my previous contribution #54, which was closed due to my unavailability and unresolved merge conflicts. I’ve now resolved all conflicts, refined the changes, and ensured full compatibility with the latest codebase.
✅ What's Updated
🔁 Refactor: Make
userreactive usingcomputedand simplify prop passinguserfrom a static variable to acomputedproperty for better reactivity.:user="user"to shorthand:userfor cleaner template usage.🛠️ Fix: Properly focus password input on error in Delete User modal
passwordInputref and reliance on$elto access native<input>inside theInputcomponent.TypeError: passwordInput.value?.focus is not a functioncaused by trying to focus the component instance instead of the actual input.formElement.passwordinside theonErrorcallback.nextTick()to ensure DOM is updated before calling.focus().💡 Why it matters
These changes enhance both UX and code maintainability:
🎥 Visual Demos (Before → After)
Here’s a visual comparison of the previous behavior vs. the updated experience:
🔁 Navbar user data updates automatically after profile changes (no page refresh needed)
🛠️ Password input now correctly focuses on error
📎 Related