Skip to content

Code review #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Code review #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d8c1dab
Consistently use var
jgonggrijp Aug 6, 2021
6d9fb6f
Don't forget the semicolons
jgonggrijp Aug 6, 2021
6a7d151
Be judicious with blank lines
jgonggrijp Aug 6, 2021
0b7407b
Docstrings
jgonggrijp Aug 6, 2021
cc703bc
Indentation
jgonggrijp Aug 6, 2021
1348cb0
"Polyfill"
jgonggrijp Aug 6, 2021
2b3000f
Use speaking names
jgonggrijp Aug 6, 2021
5f7493d
Generator functions
jgonggrijp Aug 6, 2021
ffe690c
Functional style with Underscore
jgonggrijp Aug 6, 2021
073fb4e
Remove trailing spaces
jgonggrijp Aug 6, 2021
586aa7c
Whitespace around comment blocks
jgonggrijp Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions examples/run_json_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
//
// node run_json_parser.js

lark = require('./json_parser.js')
var lark = require('./json_parser.js');

let transformer = {
var transformer = {
number: ([n]) => parseFloat(n.value),
string: ([s]) => s.value.slice(1, -1),
array: Array.from,
Expand All @@ -18,13 +18,12 @@ let transformer = {
null: () => null,
true: () => true,
false: () => false,
}

var parser = lark.load_parser({transformer})
};

var parser = lark.load_parser({transformer});

function test_json() {
text = `
var text = `
{
"empty_object" : {},
"empty_array" : [],
Expand All @@ -33,14 +32,11 @@ function test_json() {
"strings" : [ "This", [ "And" , "That", "And a \\"b" ] ],
"nothing" : null
}
`

console.log( parser.parse(text) )

`;
console.log( parser.parse(text) );
}


if (require && require.main === module) {
test_json()
test_json();
}

Loading