Skip to content

test: drop stale e2e yes flags#920

Merged
liangshuo-1 merged 1 commit into
larksuite:mainfrom
yxzhaao:fix/update-e2e-yes-flags-for-meta
May 15, 2026
Merged

test: drop stale e2e yes flags#920
liangshuo-1 merged 1 commit into
larksuite:mainfrom
yxzhaao:fix/update-e2e-yes-flags-for-meta

Conversation

@yxzhaao
Copy link
Copy Markdown
Contributor

@yxzhaao yxzhaao commented May 15, 2026

Summary

Changes

  • Change 1
  • Change 2

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark xxx command works as expected

Related Issues

  • None

Summary by CodeRabbit

  • Tests
    • Updated end-to-end test cases for calendar event management operations including event creation, updates, and RSVP workflows to reflect current CLI command behavior and expectations.
    • Updated end-to-end test cases for spreadsheet operations including resource CRUD tasks, spreadsheet patching, and filter management to align with current CLI specifications and requirements.

Review Change Stack

@github-actions github-actions Bot added the size/S Low-risk docs, CI, test, or chore only changes label May 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5444cbb9-2a2d-40dd-bb44-1ad720b7187f

📥 Commits

Reviewing files that changed from the base of the PR and between 14a3213 and f2c7046.

📒 Files selected for processing (6)
  • tests/cli_e2e/calendar/calendar_create_event_test.go
  • tests/cli_e2e/calendar/calendar_personal_event_workflow_test.go
  • tests/cli_e2e/calendar/calendar_rsvp_workflow_test.go
  • tests/cli_e2e/calendar/calendar_update_event_test.go
  • tests/cli_e2e/sheets/sheets_crud_workflow_test.go
  • tests/cli_e2e/sheets/sheets_filter_workflow_test.go
💤 Files with no reviewable changes (6)
  • tests/cli_e2e/sheets/sheets_crud_workflow_test.go
  • tests/cli_e2e/calendar/calendar_rsvp_workflow_test.go
  • tests/cli_e2e/calendar/calendar_update_event_test.go
  • tests/cli_e2e/calendar/calendar_personal_event_workflow_test.go
  • tests/cli_e2e/sheets/sheets_filter_workflow_test.go
  • tests/cli_e2e/calendar/calendar_create_event_test.go

📝 Walkthrough

Walkthrough

Calendar and sheets e2e test files remove Yes: true confirmation parameters from CLI request payloads. Changes affect event deletion cleanup in four calendar tests, spreadsheet patching in one sheets CRUD test, and filter updating in one sheets workflow test.

Changes

E2E Test Confirmation Parameter Cleanup

Layer / File(s) Summary
Calendar event deletion parameter cleanup
tests/cli_e2e/calendar/calendar_create_event_test.go, tests/cli_e2e/calendar/calendar_personal_event_workflow_test.go, tests/cli_e2e/calendar/calendar_rsvp_workflow_test.go, tests/cli_e2e/calendar/calendar_update_event_test.go
calendar events delete requests in cleanup and deletion steps remove the Yes: true confirmation field from request parameters, simplifying event deletion payloads across four calendar workflow tests.
Sheets command parameter cleanup
tests/cli_e2e/sheets/sheets_crud_workflow_test.go, tests/cli_e2e/sheets/sheets_filter_workflow_test.go
spreadsheets patch and spreadsheet.sheet.filters update requests remove the Yes: true confirmation field, aligning sheets e2e test payloads with the parameter removal pattern.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • larksuite/cli#794: Identical pattern of removing Yes: true confirmation field from e2e test CLI request parameters across calendar and sheets workflows.
  • larksuite/cli#633: Introduces the confirmation gating mechanism and --yes flag handling that this PR's test changes reflect through removal of Request.Yes parameters.
  • larksuite/cli#815: Directly matches the removal of stale Yes: true flags from e2e request params in overlapping test files.

Suggested labels

domain/calendar, size/S

Suggested reviewers

  • liangshuo-1

Poem

🐰 A confirmation parameter takes its bow,
No more "Yes: true" in workflows now,
Calendar events and spreadsheets clean,
Simpler requests than ever seen,
Our tests run lighter, trimmed just right! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description consists entirely of template placeholders with no actual content filled in—Summary, Changes, and Test Plan are unfilled templates. Fill in the Summary section with motivation and scope, provide actual Changes (not 'Change 1/2' placeholders), and update the Test Plan with how this change was verified.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'test: drop stale e2e yes flags' is specific and directly reflects the main change—removing unused Yes:true parameters from e2e test commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@f2c7046a5f7d577643b3f51bae7b7abf01ada285

🧩 Skill update

npx skills add yxzhaao/cli#fix/update-e2e-yes-flags-for-meta -y -g

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.92%. Comparing base (14a3213) to head (f2c7046).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #920   +/-   ##
=======================================
  Coverage   65.92%   65.92%           
=======================================
  Files         523      523           
  Lines       49692    49692           
=======================================
  Hits        32758    32758           
  Misses      14134    14134           
  Partials     2800     2800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liangshuo-1 liangshuo-1 merged commit 0b72156 into larksuite:main May 15, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Low-risk docs, CI, test, or chore only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants