Skip to content

fix: prefer message body fileName over Content-Disposition for non-ASCII filenames #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meijing0114 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prefer message body fileName over Content-Disposition for non-ASCII filenames #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/messaging/inbound/media-resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ export async function downloadResources(params: {
contentType = await core.media.detectMime({ buffer: result.buffer });
}

const fileName = result.fileName || res.fileName;
// Prefer the file name from the message body (res.fileName) over
// Content-Disposition (result.fileName), because Feishu may return
// raw UTF-8 bytes in the header that get misinterpreted as Latin1
// by Node.js HTTP clients, producing garbled non-ASCII filenames.
const fileName = res.fileName || result.fileName;
const saved = await core.channel.media.saveMediaBuffer(result.buffer, contentType, 'inbound', maxBytes, fileName);

const placeholder = inferPlaceholderFromType(res.type);
Expand Down