Bugfix/custom url is not working on docker #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
CI is broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to use Mirage with docker it will fail because:
Mirage.start (runner.rb:14)it put default port. After that inMirage::Clientthis if elsif(client.rb:15)will never use custom url because at first it check if there is port and if it could find itlocalhostis used.Runner.startit useMirage.running?(options)-(runner.rb:91)withHashtype param. Because of that it will always try to find if app is running aslocalhostnot u custom url.I tried to fix this error with backward compatibility. Classes interface stay almost this same.