#122 Correction Package Refactor — Complete Redesign

[mmaclay]

The is the PR for epic #122 - and it will track changes from the sub-issues.

Correction Package Refactor — Complete Redesign

Top-level tracking issue for a complete refactor and architectural redesign of curryer.correction.

Goals

• Move to Pydantic config models; remove ad-hoc dataclasses
• Remove user-supplied loader protocols; internalize data loading as config-driven
• Split correction.py monolith into focused, testable modules
• Add key deliverables: verification mode & GCP regridding tool
• Lay groundwork for future CurryerConfig unifying all of curryer

PR Groupings & Sub-Issues

PR 1: Foundation — Naming & Module Split

• Rename GeolocationConfig disambiguations & error_stats.py
• Break up correction.py monolith into focused modules

PR 2: Config Redesign — Pydantic, Internalize Loading, Search Strategies

• Introduce Pydantic CorrectionConfig with typed sub-models
• Remove loader protocols — internalize data loading
• Add SearchStrategy enum for deterministic parameter sweeps

PR 3: New Features — Verification & GCP Regridding

• Add verification module
• Add gcp_regrid module

PR 4: Test Cleanup & Future Planning

• Restructure test_correction/
• Tracking: extend pydantic config pattern to all of curryer

Dependency Graph

PR 1 (Foundation)
├─ Renames (unblocks everything)
└─ Module split (unblocks everything)
    │
    ▼
PR 2 (Config & Loading)
├─ Pydantic config (unblocks loader removal + search strategies)
├─ Remove protocols (depends on pydantic config)
└─ Search strategies (depends on pydantic config)
    │
    ▼
PR 3 (Features) — can start in parallel with PR 2 by stubbing config
├─ Verification module
└─ GCP regridding module
    │
    ▼
PR 4 (Cleanup)
├─ Test restructuring
└─ Future config tracking

Context

• No external users of the correction package yet — breaking changes are acceptable
• Pydantic introduced here will serve as the prototype for a future curryer-wide config system
• CLARREO-specific code stays in tests/examples only; main library must be mission-agnostic

[codecov]

Codecov Report

❌ Patch coverage is 80.80761% with 827 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.52%. Comparing base (996cc37) to head (d6bb926).

Files with missing lines	Patch %	Lines
curryer/correction/pipeline.py	34.12%	220 Missing and 29 partials ⚠️
curryer/correction/parameters.py	61.79%	76 Missing and 26 partials ⚠️
curryer/correction/image_io.py	66.77%	78 Missing and 21 partials ⚠️
curryer/correction/regrid.py	67.52%	64 Missing and 12 partials ⚠️
curryer/correction/config.py	78.27%	36 Missing and 27 partials ⚠️
curryer/correction/kernel_ops.py	51.57%	39 Missing and 7 partials ⚠️
tests/test_correction/clarreo/_pipeline_helpers.py	65.85%	39 Missing and 3 partials ⚠️
tests/test_correction/_synthetic_helpers.py	61.25%	30 Missing and 1 partial ⚠️
tests/test_correction/test_pipeline.py	72.22%	25 Missing ⚠️
curryer/correction/results_io.py	84.66%	11 Missing and 12 partials ⚠️
... and 13 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   73.62%   76.52%   +2.89%     
==========================================
  Files          67       90      +23     
  Lines       10655    12303    +1648     
  Branches     1204     1331     +127     
==========================================
+ Hits         7845     9415    +1570     
- Misses       2343     2388      +45     
- Partials      467      500      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.