Skip to content

feat(cli): deploy BatchStoreModule #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(cli): deploy BatchStoreModule #3813

wants to merge 3 commits into from

Conversation

frolic
Copy link
Member

@frolic frolic commented Sep 9, 2025 •
edited
Loading

needed for #3812
closes #1445

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bdad072

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
id.place Ready Ready Preview Comment Sep 9, 2025 3:36am

@frolic frolic marked this pull request as ready for review September 9, 2025 08:55
@frolic frolic requested a review from alvrs as a code owner September 9, 2025 08:55
@frolic frolic changed the title add BatchStoreModule feat(cli): add BatchStoreModule Sep 9, 2025
@frolic frolic changed the title feat(cli): add BatchStoreModule feat(cli): deploy BatchStoreModule Sep 9, 2025
alvrs
alvrs reviewed Sep 9, 2025
View reviewed changes
packages/world-module-batchstore/src/BatchStoreSystem.sol
ResourceId tableId,
bytes32[][] memory keyTuples
) external view returns (TableRecord[] memory records) {
AccessControl._requireAccess(tableId, _msgSender());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need access control the read function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoops, copy pasta mistake

frolic
frolic commented Sep 10, 2025
View reviewed changes
packages/world-module-batchstore/src/BatchStoreSystem.sol

function setTableRecords(ResourceId tableId, TableRecord[] memory records) external {
AccessControl._requireAccess(tableId, _msgSender());

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to get field layout here to save gas

frolic
frolic commented Sep 10, 2025
View reviewed changes
packages/world-module-batchstore/src/BatchStoreSystem.sol
}

function deleteTableRecords(ResourceId tableId, bytes32[][] memory keyTuples) external {
AccessControl._requireAccess(tableId, _msgSender());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be requireAccess rather than _requireAccess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add events/methods for batch get/set/delete record
2 participants
@frolic @alvrs