Repository navigation
Preserve broker containers in killall cleanup - #197
Merged
nickjalbert merged 3 commits intoOct 6, 2026
Merged
Conversation
Contributor
|
LGTM! Thanks! |
nickjalbert
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup candidate query matches
shellm-*containers, including persistent brokers, despite the script's documented promise to leave brokers running. Exclude containers labeledshellm.broker=1from the candidate query and its normal/dry-run listings. Keep the existing separate broker report.Closes #196.
Validation: two Ubuntu regression tests run the actual complete script with isolated process enumeration and a Docker CLI fixture containing a per-run sandbox and persistent broker. They verify normal cleanup targets only the sandbox, dry-run performs no removal, both listings exclude brokers from candidates, and the separate broker report remains. Both tests pass with the fix and fail on the original candidate query. Tests are included in the existing shell harness.
git diff --checkpasses. Docker CLI/filter behavior is simulated; no real daemon or container removal was exercised. Current-commit CI is pending.