Skip to content

fix: Ensure PlatformScheduleAction order is preserved #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Ensure PlatformScheduleAction order is preserved #176

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a0c0cc
fix: Ensure PlatformScheduleAction order is preserved
jsonbailey Oct 21, 2025
bb49069
try linking actions to avoid wait
jsonbailey Oct 23, 2025
e0169d4
use the default and run the continuation task async
jsonbailey Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkgs/sdk/client/src/PlatformSpecific/AsyncScheduler.netstandard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@ namespace LaunchDarkly.Sdk.Client.PlatformSpecific
{
internal static partial class AsyncScheduler
{
private static volatile Task _lastScheduledTask = Task.CompletedTask;

private static void PlatformScheduleAction(Action a)
{
Task.Run(a);
// Chain the new action to run after the previous one completes
// This ensures actions run in order while maintaining fire-and-forget behavior
_lastScheduledTask = _lastScheduledTask.ContinueWith(_ => a());
Copy link

@cursor cursor bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Race Condition in Task Scheduler

There's a race condition in PlatformScheduleAction. Concurrent calls can cause _lastScheduledTask to be updated non-atomically, which breaks the intended sequential ordering of scheduled tasks. This means tasks may execute out of order or in parallel, as volatile doesn't ensure atomicity for read-modify-write operations.

Fix in Cursor Fix in Web

}
}
}
Loading