feat: Otel TracingHook implementation and repo skeleton #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs a top level README. |
kinyoklion
reviewed
Apr 18, 2024
| @@ -0,0 +1,2 @@ | |||
| # Repository Maintainers | |||
| * @launchdarkly/team-sdk-java | |||
There was a problem hiding this comment.
This says it is missing permissions at the moment, so you may need to double check the repo labels versus the team requirements.
There was a problem hiding this comment.
I think the query is query = "org:launchdarkly topic:launchdarkly-sdk language:Java" , and I think the language tag is automatically derived. Does that sound plausible? If so, I think we have to merge something before this will know the repo is for java.
There was a problem hiding this comment.
It does sound plausible. You may need to trigger a terraform run after merging this.
kinyoklion
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
236794
Describe the solution you've provided
Implementation of SDK Hook interface that records spans and events for feature flag evaluations using the OpenTelemetry API.