ci: updating nexus publish plugin version #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
requested review from
louis-launchdarkly and
kinyoklion
and removed request for
louis-launchdarkly
kinyoklion
reviewed
May 28, 2024
lib/shared/common/build.gradle.kts
Outdated
| username.set(ossrhUsername) | ||
| password.set(ossrhPassword) | ||
| } | ||
| sonatype {} |
There was a problem hiding this comment.
I had to use findProperty to get the username/password here. Which allowed it to be undefined in development and populated for releases. Does some other magic make that not required?
There was a problem hiding this comment.
From my local testing, commands of this form work.
./gradlew <task> -PsonatypeUsername=<username> -PsonatypePassword=<password>
And this is what the publish script uses.
There was a problem hiding this comment.
It also works when they are of form:
./gradlew <task>
There was a problem hiding this comment.
Should be resolved based on slack discussion.
kinyoklion
reviewed
May 28, 2024
kinyoklion
approved these changes
May 28, 2024
kinyoklion
approved these changes
May 28, 2024
kinyoklion
requested changes
May 28, 2024
kinyoklion
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating nexus plugin