fix: Handle default flush interval for browser SDK. #822
+40
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
kinyoklion
force-pushed
the
rlamb/correct-browser-defaults
branch
3 times, most recently
from
a637e8d to
95eaedf
Compare
kinyoklion
force-pushed
the
rlamb/correct-browser-defaults
branch
from
95eaedf to
1abe883
Compare
abarker-launchdarkly
approved these changes
Apr 15, 2025
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Apr 15, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>browser-telemetry: 1.0.5</summary> ## [1.0.5](browser-telemetry-v1.0.4...browser-telemetry-v1.0.5) (2025-04-15) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-client-sdk bumped from 0.5.1 to 0.5.2 </details> <details><summary>js-client-sdk: 0.5.2</summary> ## [0.5.2](js-client-sdk-v0.5.1...js-client-sdk-v0.5.2) (2025-04-15) ### Bug Fixes * Handle default flush interval for browser SDK. ([#822](#822)) ([2c1cc7a](2c1cc7a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser SDK was incorrectly handling its default flush interval configuration.
There are two layers to defaults for the browser SDK. The first is defaults which differ from the base configuration defaults, second is defaults for browser specific configuration.
The base defaults were being applied to the browser specific configuration, which meant those changes were being lost and instead the base default was being used instead.
Fixes: SDK-1199