feat: Adding agent support for AI Configs #893
Conversation
|
@launchdarkly/browser size report |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
ctawiah
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_18dafc40-282b-4e1b-ab38-6508e582def5). |
| agents<const T extends readonly LDAIAgentConfig[]>( | ||
| agentConfigs: T, | ||
| context: LDContext, | ||
| ): Promise<Record<T[number]['key'], LDAIAgent>>; |
There was a problem hiding this comment.
Why does agents have typing related to LDAIAgentConfig and takes configs but agent (singular) up above does not?
There was a problem hiding this comment.
The .agents function takes a list of keys as input and returns a map using those same keys. The typing ensures that the editor's IntelliSense can provide accurate suggestions when retrieving values, its to help users access only the keys they originally passed in.
|
|
||
| await Promise.all( | ||
| agentConfigs.map(async (config) => { | ||
| const agent = await this._evaluateAgent( |
There was a problem hiding this comment.
Can this promise encounter any errors/failures?
There was a problem hiding this comment.
The _evaluateAgent function calls the underlying LaunchDarkly client, which shouldn’t produce any errors, my understanding is that our SDKs are designed not to return errors during evaluation.
|
CI Check is failing. |
Fixed |
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.