feat: Add hook support. #116
Merged
+1,062
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
force-pushed
the
rlamb/add-hooks-support
branch
from
a3a6163 to
9c4589b
Compare
kinyoklion
commented
Apr 9, 2025
src/HookRunner.js
Outdated
There was a problem hiding this comment.
Based on the implementation from js-core, but using a factory instead of a class.
kinyoklion
commented
Apr 9, 2025
tanderson-ld
reviewed
Apr 9, 2025
| if (streamActive) { | ||
| connectStream(); | ||
| } | ||
| return flagValueMap; | ||
| }) | ||
| .catch(err => { | ||
| afterIdentify?.({ status: 'error' }); |
There was a problem hiding this comment.
Seems possible that after identify could be invoked twice if an error is thrown in connectStream? Perhaps not realistically possible.
There was a problem hiding this comment.
I've added a once helper.
The way this promise chaining is structured is terrible, but I don't want to substantially change it for this. So the once will ensure it is only called once.
tanderson-ld
approved these changes
Apr 10, 2025
kinyoklion
pushed a commit
that referenced
this pull request
Apr 21, 2025
🤖 I have created a release *beep* *boop* --- ## [5.5.0](5.4.0...5.5.0) (2025-04-21) ### Features * Add hook support. ([#116](#116)) ([85c227c](85c227c)) * Inline context in custom events. ([#118](#118)) ([450f8f7](450f8f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as tests need added first.