Skip to content

feat(components): update DialogTrigger popover padding #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+10 −1
Open

feat(components): update DialogTrigger popover padding #1760

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bd6996
feat(components): update DialogTrigger popover padding
devin-ai-integration[bot] Aug 28, 2025
08ef974
fix(components): correct horizontal padding to var(--lp-spacing-500)
devin-ai-integration[bot] Aug 28, 2025
e8c1918
chore: add changeset for DialogTrigger padding update
devin-ai-integration[bot] Aug 28, 2025
6b2a1b2
refactor(components): use explicit size tokens instead of spacing tokens
devin-ai-integration[bot] Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/styles/Popover.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
}

&[data-trigger='DialogTrigger'] {
padding: var(--lp-spacing-300);
padding: var(--lp-spacing-400) var(--lp-spacing-500);
Copy link
Contributor

@matthewferry matthewferry Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: replace spacing tokens with explicit sizes

Suggested change
padding: var(--lp-spacing-400) var(--lp-spacing-500);
padding: var(--lp-size-12) var(--lp-size-16);

}

&[data-trigger='ComboBoxDialog'] {
Expand Down
Loading