chore: honor restic retention settings #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 ,
I hope this finds you well.
There is a discrepancy between the documentation/examples for backup snapshots retention and the actual code.
According to README and
stack-back.env.template
one should useRESTIC_
prefix with theKEEP_*
env variables for the retentions settings.However in
config.py
it will fetch just theKEEP_*
env variables, i.e. without the prefix. If one defines the backup retention using theRESTIC_
prefix, the retention will fall back to default values.This PR takes both approaches into account, since someone may be already using the
KEEP_*
variant. Hence it is not introducing any break changes.