Skip to content

chore: honor restic retention settings #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

igolman
Copy link
Contributor

@igolman igolman commented Jun 10, 2025

Hi 👋 ,

I hope this finds you well.

There is a discrepancy between the documentation/examples for backup snapshots retention and the actual code.
According to README and stack-back.env.template one should use RESTIC_ prefix with the KEEP_* env variables for the retentions settings.
However in config.py it will fetch just theKEEP_* env variables, i.e. without the prefix. If one defines the backup retention using the RESTIC_ prefix, the retention will fall back to default values.

This PR takes both approaches into account, since someone may be already using the KEEP_* variant. Hence it is not introducing any break changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant