Skip to content

Update multiple files with unnecessary code.#4526

Closed
depleur wants to merge 4 commits intolayer5io:masterfrom
depleur:master
Closed

Update multiple files with unnecessary code.#4526
depleur wants to merge 4 commits intolayer5io:masterfrom
depleur:master

Conversation

@depleur
Copy link
Contributor

@depleur depleur commented Jul 11, 2023

Description

This PR fixes #4521

Notes for Reviewers

Fixed multiple instances of the {" "} string in code.

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/landscape The service mesh landscape area/blog New posts or new blog functionality area/learn Related to /learn section area/events area/careers area/resources area/handbook project/kanvas labels Jul 11, 2023
@l5io
Copy link
Contributor

l5io commented Jul 11, 2023

🚀 Preview for commit 8382eed at: https://64acfda428607248eb46b9e2--layer5.netlify.app

@samyakshah3008 samyakshah3008 mentioned this pull request Jul 12, 2023
1 task
@Nikhil-Ladha
Copy link
Contributor

@randychilau are you addressing this in your open PR, if so I would have to politely ask @depleur to close out this PR in your favour to avoid unwanted hustle

@randychilau
Copy link
Contributor

@randychilau are you addressing this in your open PR

Hi @Nikhil-Ladha,

Thanks for the message.

I did not address the instances of {" "} in mdx files in my PR, and do not believe there is any overlap/conflict with this PR.

Cheers,
Randy

@depleur
Copy link
Contributor Author

depleur commented Jul 13, 2023

Hey, I accidentally added a commit to this PR which actually should be in a PR of its own as it resolves another issue. Is there anything I can do?

@Nikhil-Ladha
Copy link
Contributor

Hey, I accidentally added a commit to this PR which actually should be in a PR of its own as it resolves another issue. Is there anything I can do?

Undo the changes and commit them

@github-actions github-actions bot removed the area/ci label Jul 14, 2023
@depleur
Copy link
Contributor Author

depleur commented Jul 14, 2023

Hey, can someone help me with conflict resolution on the index.js file?

@vishalvivekm
Copy link
Contributor

@depleur

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

@samyakshah3008
Copy link
Member

Hi @depleur you are left to sign off the DCO check as well.
Please do

depleur added 2 commits July 25, 2023 17:27
Signed-off-by: Namit Arjaria <89105989+depleur@users.noreply.github.com>
Signed-off-by: Namit Arjaria <89105989+depleur@users.noreply.github.com>
@Chadha93
Copy link
Member

@depleur heads-up: merge conflicts...

@thisiskaransgit
Copy link
Contributor

Hey @depleur, let's wrap this up soon, also please update the PR title 🙄

@leecalcote
Copy link
Member

Thanks for this, @depleur.

P.S. Smaller PRs = Quicker review. :)

@github-actions
Copy link

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Chadha93
Copy link
Member

@depleur... Reminder, let's close this pr if not updated by Friday.

@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 15, 2023
@abhijeetgauravm
Copy link
Contributor

Closing this as the issue is fixed by #4715 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/blog New posts or new blog functionality area/careers area/events area/handbook area/landscape The service mesh landscape area/learn Related to /learn section area/resources issue/remind issue/stale Issue has not had any activity for an extended period of time project/kanvas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI]: unwanted {" "} in blog content

10 participants