Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much spaces between contribution and General contribution flow 2 #4694

Closed

Conversation

sarkartanmay393
Copy link
Contributor

@sarkartanmay393 sarkartanmay393 commented Aug 4, 2023

Description

This PR fixes #

Issue: #4636

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@sarkartanmay393
Copy link
Contributor Author

@Ghat0tkach There's new code with no extra indentations

@Ghat0tkach
Copy link
Member

Ghat0tkach commented Aug 4, 2023

@sarkartanmay393
I think this will solely fix the issue isnt it
#4636 (comment)

Edit: please No Pull request untill assignment.
We do appreciate your enthusiasm to contribute to layer5 projects but lets keep the spirit of open-source alive as well.
We do follow first come first serve assignment of issues .
Exceptions do exist and I dont think this one comes under exception 😅.

Please take care of these things from near future

@sarkartanmay393
Copy link
Contributor Author

@Ghat0tkach I don't see so. If only decrease the margin-top -46, it will fix in mentioned pages but destroy already looking good pages.

Screen.Recording.2023-08-04.at.10.52.32.PM.-.01.mov

Yeah, sure. Sorry for my behaviour though. 🙏🏼

@l5io
Copy link
Contributor

l5io commented Aug 4, 2023

🚀 Preview for commit 9fb56ff at: https://64cd348129c95438bffdbd4b--layer5.netlify.app

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarkartanmay393 Agree with the mentioned point. It may change the layout of other pages

Meanwhile, the changes you've made solved the issue. I feel the preview is as expected.

@Ghat0tkach
Copy link
Member

Hey @sarkartanmay393

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@l5io
Copy link
Contributor

l5io commented Aug 7, 2023

🚀 Preview for commit 369bf63 at: https://64d0b22a8bc4d050a865142c--layer5.netlify.app

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarkartanmay393, we will be needing to update the current style not introduce new ones

@Chadha93
Copy link
Member

@sarkartanmay393, we will be needing to update the current style not introduce new ones

@sam1code, thoughts?

@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/handbook issue/stale Issue has not had any activity for an extended period of time
Development

Successfully merging this pull request may close these issues.

7 participants