docs: close core ty override debt - #182
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Closes the remaining documentation/contract collateral for the already-shipped ty override cleanup by updating planning/steward guidance to reflect the default-severity policy, and making that policy executable via a regression test.
Changes:
- Add a focused contract test that fails if
pyproject.tomlreintroducesunresolved-attributeoverrides undertool.ty.overrides. - Update parser/compiler steward contracts to explicitly protect “default ty severity” (no core
unresolved-attributeoverrides without contract review). - Mark historical planning RFCs as completed and remove issue #142 from the active planning index.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_type_config_contract.py |
Adds a regression test enforcing that unresolved-attribute is not overridden in tool.ty.overrides. |
src/kida/parser/AGENTS.md |
Updates parser steward invariants/checklist to prohibit restoring core unresolved-attribute overrides. |
src/kida/compiler/AGENTS.md |
Updates compiler steward invariants/checklist to prohibit restoring core unresolved-attribute overrides. |
plan/rfc-type-suppression-reduction.md |
Updates historical RFC status/note to reflect completion of core ty override cleanup and link to #142/#176. |
plan/rfc-type-checking-strategy.md |
Updates the NOTE to reflect override debt completion and link to #142/#176. |
plan/rfc-mixin-protocol-typing.md |
Marks the RFC as implemented and updates the NOTE to reflect override removal and link to #142/#176. |
plan/README.md |
Removes #142 from the “Active issue” planning index row now that it is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unresolved-attributeoverridesWhy
PR #176 removed all three core
unresolved-attribute = "warn"override blocks, but the planning RFCs and scoped steward guidance still described that debt as active. That stale guidance could route future work toward an already-completed migration or allow the broad overrides to return unnoticed.Impact
No runtime, syntax, public API, or generated-output behavior changes. This closes the documentation and maintenance-contract collateral for the shipped type-check cleanup.
Verification
make lintmake format-checkmake tyuv run pytest tests/test_type_config_contract.py -q(1 passed)make test(4,451 passed, 5 skipped)git diff --checkSteward Notes
unresolved-attributeoverrides without contract review.Closes #142.