fix: consolidate duplicate ty workflows - #183
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Consolidates CI type-checking by removing the standalone ty.yml workflow and relying on the Type Check (ty) job in tests.yml as the single authoritative ty lane, with supporting contract coverage and documentation updates.
Changes:
- Deleted
.github/workflows/ty.ymlto eliminate the duplicatetyworkflow. - Added a workflow contract test to assert a single authoritative
tylane remains in CI. - Documented the authoritative lane in the stability gate doc and added a changelog fragment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/templates/test_github_report_contracts.py |
Adds a workflows-dir constant and a new contract test asserting a single authoritative ty CI lane. |
docs/stability-gate.md |
Documents that Type Check (ty) in tests.yml is the authoritative CI type-check lane. |
changelog.d/138.changed.md |
Notes the CI consolidation so PRs run one authoritative type-check lane. |
.github/workflows/ty.yml |
Removes the duplicate standalone ty workflow. |
Comment on lines
+40
to
+42
| assert "ty.yml" not in workflows | ||
| assert sum("uv run ty check src/kida\n" in workflow for workflow in workflows.values()) == 1 | ||
| assert "name: Type Check (ty)" in workflows["tests.yml"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the duplicate standalone
ty.ymlworkflow and keep the report-producingType Check (ty)job intests.ymlas the single authoritative lane. Add a workflow contract test, stability-gate note, and changelog fragment.Why
Kida ran the same ty command twice on every push and pull request. The surviving CI job preserves raw failure output and the rendered JUnit report. The active main ruleset has no required status check tied to the removed
type-checkname.Verification
make verify-stabilitySteward Notes
Consulted the GitHub Workflow, Test Corpus, and Internal Docs stewards. Permissions, cache keys, artifacts, release/publish behavior, public APIs, schemas, examples, and benchmarks are unchanged.
Closes #138.