Add support for X509 signature algorithms such as RSA-SHA1 and ECDSA-with-SHA384#130
Merged
leafo merged 1 commit intoleafo:masterfrom Oct 17, 2022
Merged
Add support for X509 signature algorithms such as RSA-SHA1 and ECDSA-with-SHA384#130leafo merged 1 commit intoleafo:masterfrom
leafo merged 1 commit intoleafo:masterfrom
Conversation
Author
|
It doesn't look like the unit tests are executed by github. |
Owner
|
Thanks, I'm fine with this for now until we get a more robust solution |
1 task
|
@leafo Do you have any timeline when a new release will be made, so kong can update its dependencies and crunchy postgres operator will be usable with it again? |
Owner
|
@wombat Sorry about the delay. Don't hesitate to bug me about pushing out a new version. Sometimes I sit on some changes for a bit in case other things come up. I've just released 1.16 to opm and luarocks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using ECDSA certificate, the signature name is the full name (e.g., ecdsa-with-SHA384), but indeed should be the digest part only (e.g., SHA384). Similarly, RSA-SHA1 is broken now because it doesn't start with SHA1 hence it doesn't get replace with SHA256.
This PR fixes both of these problems.
It's an alternative proposal to #127 that works for all socket types but I didn't touch cqueues because I was not sure why it was hardcoded as SHA256.