Fix comment stripping crash on /- inside string literals#20
Merged
Conversation
The crawler has been failing since March 27 because mathlib4 added scripts/find_command_range.lean which contains /- inside a string literal (e.g. `s.startsWith "/-"`). The comment stripper was treating this as a block comment start, then failing to find the closing -/. Add _find_outside_strings() helper that skips string literals when searching for comment delimiters at the top level. Inside block comments, strings are not special per Lean's grammar, so the existing behavior is preserved there. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/find_command_range.leanwas added to mathlib4 containing/-inside a string literal (e.g.s.startsWith "/-")LeanParseError: Cannot find closing comment delimiter_find_outside_strings()helper that skips string literals when searching for/-and--delimiters at the top level. Inside block comments, strings are not special per Lean's grammar, so existing behavior is preserved.Test plan
/-inside string literals (alone and mixed with real comments)find_command_range.lean🤖 Generated with Claude Code