Skip to content

feat(FieldTheory/KrullTopology): generalize theorems - #36100

Closed
plp127 wants to merge 5 commits into
leanprover-community:masterfrom
plp127:aliu/infgaldep
Closed

feat(FieldTheory/KrullTopology): generalize theorems#36100
plp127 wants to merge 5 commits into
leanprover-community:masterfrom
plp127:aliu/infgaldep

Conversation

@plp127

@plp127 plp127 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Simultaneously generalize IntermediateField.fixingSubgroup_isClosed and InfiniteGalois.fixingSubgroup_isClosed to algebraic extensions.


Open in Gitpod

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

PR summary a99960b7a0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IntermediateField.isClosed_fixingSubgroup

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 4, 2026

@vihdzp vihdzp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some minor suggestions which are mostly unrelated to the PR. Otherwise LGTM

@@ -196,7 +180,7 @@ lemma fixingSubgroup_fixedField (H : ClosedSubgroup Gal(K/k)) [IsGalois k K] :
/-- The Galois correspondence from intermediate fields to closed subgroups. -/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more important than the docstring is giving it credit for.

Suggested change
/-- The Galois correspondence from intermediate fields to closed subgroups. -/
/-- The **Galois correspondence** from intermediate fields to closed subgroups. -/

Comment thread Mathlib/FieldTheory/KrullTopology.lean Outdated
plp127 and others added 3 commits March 4, 2026 19:20
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
@plp127

plp127 commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

closing in favor of #36239

@plp127 plp127 closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants