feat(FieldTheory/KrullTopology): generalize theorems - #36100
Closed
plp127 wants to merge 5 commits into
Closed
Conversation
PR summary a99960b7a0Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
vihdzp
approved these changes
Mar 4, 2026
vihdzp
left a comment
Collaborator
There was a problem hiding this comment.
I've made some minor suggestions which are mostly unrelated to the PR. Otherwise LGTM
| @@ -196,7 +180,7 @@ lemma fixingSubgroup_fixedField (H : ClosedSubgroup Gal(K/k)) [IsGalois k K] : | |||
| /-- The Galois correspondence from intermediate fields to closed subgroups. -/ | |||
Collaborator
There was a problem hiding this comment.
This seems more important than the docstring is giving it credit for.
Suggested change
| /-- The Galois correspondence from intermediate fields to closed subgroups. -/ | |
| /-- The **Galois correspondence** from intermediate fields to closed subgroups. -/ |
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
Contributor
Author
|
closing in favor of #36239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simultaneously generalize
IntermediateField.fixingSubgroup_isClosedandInfiniteGalois.fixingSubgroup_isClosedto algebraic extensions.