[Merged by Bors] - feat(Data/List): Nodup and head & getLast lemmas#38830
[Merged by Bors] - feat(Data/List): Nodup and head & getLast lemmas#38830Jun2M wants to merge 15 commits into
Conversation
PR summary 0927d675deImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Snir Broshi <26556598+SnirBroshi@users.noreply.github.com>
|
This pull request has conflicts, please merge |
joneugster
left a comment
There was a problem hiding this comment.
Thank you for the PR!
|
thank you! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
b-mehta
left a comment
There was a problem hiding this comment.
This PR looks good to me, but I agree with Jon's point above.
ocfnash
left a comment
There was a problem hiding this comment.
I'd like a bit more thought about API here.
This reverts commit 80e503a.
There was a problem hiding this comment.
I'm sorry to have been the cause of delaying this PR for so long.
Looking more closely now I retract my comment here as I now realise the moral duplication is a legacy of the fact that List.filter consumes a Bool-valued predicated whereas Finset.filter consumes a Prop-valued predicate. It's not pretty that we are in this situation and therefore have to author these morally duplicate lemmas (to enable convenient rewriting in each direction) but I do now agree that it is the best local action we can take.
Thanks for your patience.
|
@Jun2M I'll also repeat Jon's remark that you need to take action to get your PR back in the review queue or else it remains almost invisible to us. bors merge |
Given a Nodup list: * If a prefix contains the last element, they are equal * If a suffix contains the first element, they are equal * If an infix contains the first element, it is a prefix * If an infix contains the last element, it is a suffix * If the first and the last element are the same, it is a singleton * `countP` is cardinality of the filter of `toFinset`. Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Oliver Nash <github@olivernash.org>
|
Pull request successfully merged into master. Build succeeded: |
Given a Nodup list:
If a prefix contains the last element, they are equal
If a suffix contains the first element, they are equal
If an infix contains the first element, it is a prefix
If an infix contains the last element, it is a suffix
If the first and the last element are the same, it is a singleton
countPis cardinality of the filter oftoFinset.