Skip to content

chore(CategoryTheory/Limits/HasLimit): use to_dual - #41017

Draft
JovanGerb wants to merge 6 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-HasLimit
Draft

chore(CategoryTheory/Limits/HasLimit): use to_dual#41017
JovanGerb wants to merge 6 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-HasLimit

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

This PR uses to_dual to generate stuff about HasColimit from HasLimit.


Open in Gitpod

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

PR summary 6a2451831e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

++ instance (priority := 100) {J : Type u₁} [Category.{v₁} J]
- HasColimit.isoOfNatIso
- HasColimit.mk
- HasColimits
- HasColimits.hasColimitsOfShape
- colimMap
- colimit
- colimit.cocone
- colimit.coconeMorphism
- colimit.coconeMorphism_hom
- colimit.cocone_x
- colimit.cocone_ι
- colimit.comp_coconePointUniqueUpToIso_hom
- colimit.comp_coconePointUniqueUpToIso_inv
- colimit.desc
- colimit.desc_cocone
- colimit.desc_extend
- colimit.existsUnique
- colimit.hom_ext
- colimit.isColimit
- colimit.isColimit_desc
- colimit.isoColimitCocone
- colimit.isoColimitCocone_ι_hom
- colimit.isoColimitCocone_ι_inv
- colimit.map_desc
- colimit.w
- colimit.ι
- colimit.ι_coconeMorphism
- colimit.ι_desc
- getColimitCocone
- hasColimit_iff_of_iso
- instance (priority := 100) hasColimitOfHasColimitsOfShape {J : Type u₁} [Category.{v₁} J]
- instance (priority := 100) hasColimitsOfShapeOfHasColimitsOfSize {J : Type u₁} [Category.{v₁} J]
- instance (priority := 100) hasLimitOfHasLimitsOfShape {J : Type u₁} [Category.{v₁} J]
- instance (priority := 100) hasLimitsOfShapeOfHasLimits {J : Type u₁} [Category.{v₁} J]
- isIso_colimMap
- ι_colimMap

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 6a24518).

  • +5 new declarations
  • −5 removed declarations
-CategoryTheory.Limits.HasColimits.hasColimitsOfShape
+CategoryTheory.Limits.HasColimits.has_colimits_of_shape
-CategoryTheory.Limits.hasColimitOfHasColimitsOfShape
-CategoryTheory.Limits.hasColimitsOfShapeOfHasColimitsOfSize
-CategoryTheory.Limits.hasLimitOfHasLimitsOfShape
-CategoryTheory.Limits.hasLimitsOfShapeOfHasLimits
+CategoryTheory.Limits.instHasColimitOfHasColimitsOfShape
+CategoryTheory.Limits.instHasColimitsOfShapeOfHasColimitsOfSize
+CategoryTheory.Limits.instHasLimitOfHasLimitsOfShape
+CategoryTheory.Limits.instHasLimitsOfShapeOfHasLimitsOfSize

Decrease in strong tech debt: (relative, absolute) = (3.00, 0.00)
Current number Change Type (strong)
7113 -3 backward.isDefEq.respectTransparency
No changes to weak technical debt.

Current commit 6a2451831e
Reference commit d732046e27

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-category-theory Category theory label Jun 25, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 8, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot added tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-category-theory Category theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant