Skip to content

fix: typo in simps error messages#41984

Open
fpvandoorn wants to merge 2 commits into
leanprover-community:masterfrom
fpvandoorn:simps_typo
Open

fix: typo in simps error messages#41984
fpvandoorn wants to merge 2 commits into
leanprover-community:masterfrom
fpvandoorn:simps_typo

Conversation

@fpvandoorn

@fpvandoorn fpvandoorn commented Jul 21, 2026

Copy link
Copy Markdown
Member
  • Remove trailing underscores in names simps-errors would erroneously print
  • Restore Lean 3 error message tests.

Open in Gitpod

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR summary 325ef0e865

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ failure1
+ failure2
+ failure3
+ specify5

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 325ef0e).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 325ef0e865
Reference commit 6e593caa39

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label Jul 21, 2026
@grunweg

grunweg commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Thanks, this is a clear improvement. I'm not 100% confident in assessing that e.g. the old and new tests correspond, so would like another pair of eyes on this:
maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 21, 2026
Comment thread MathlibTest/Simps.lean

/--
error: Invalid simp lemma failure1_fst_fst.
Projection doesn't exist, because target Nat is not a structure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not say:

Suggested change
Projection doesn't exist, because target Nat is not a structure.
Projection fst doesn't exist, because target Nat is not a structure.

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants