feat(FreeGroup): characterize commutative/cyclic free groups#41988
feat(FreeGroup): characterize commutative/cyclic free groups#41988vlad902 wants to merge 6 commits into
Conversation
PR summary 551b1cb5a7Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| rw [zpow_sub_one] | ||
| exact h_inv _ ih | ||
|
|
||
| @[to_additive] |
There was a problem hiding this comment.
this instance is just moved to an earlier file
Characterize cyclic/commutative free groups as being those on ≤ 1 generators. I generalize the Subsingleton => IsCyclic instance along the way to reduce new imports.
c400c5a to
9a6925d
Compare
| mul_left_cancel := fun a {b c} h ↦ by | ||
| rw [← inv_mul_cancel_left a b, show a * b = a * c from h, inv_mul_cancel_left] | ||
|
|
||
| @[to_additive] |
There was a problem hiding this comment.
This instance is just moved to an earlier file. I'd argue that since IsCyclic is defined in this file that it's reasonable to also state that the trivial group is cyclic here as well, but if Algebra.Group.Defs is too early, I could rename SpecificGroups.Cyclic.Basic to Cyclic.ZMod and then have SpecificGroups.Cyclic.Basic only import Algebra.Group.Basic with these two instances instead?
Characterize cyclic/commutative free groups as being those on ≤ 1 generators. I generalize and move around some instances along the way to avoid new imports.