feat(Tactic/Linter/UnusedTactic): mark isIgnoreTacticKind and addIgnoreTacticKind as public#41993
feat(Tactic/Linter/UnusedTactic): mark isIgnoreTacticKind and addIgnoreTacticKind as public#41993eneoli wants to merge 2 commits into
isIgnoreTacticKind and addIgnoreTacticKind as public#41993Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 6bb1fd1237Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
isIgnoreTacticKind and addIgnoreTacticKind as publicisIgnoreTacticKind and addIgnoreTacticKind as public
joneugster
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I've been a bit confused at first, so I've added an optional suggestion for a comment about the thing I've been confused about.
maintainer merge
| macro_rules | ||
| | `(command| doNotEmitWarning $tac) => `(command| example : True := by $tac ; constructor) | ||
|
|
||
| #eval Mathlib.Linter.UnusedTactic.addIgnoreTacticKind ``doNotEmitWarningStx |
There was a problem hiding this comment.
| #eval Mathlib.Linter.UnusedTactic.addIgnoreTacticKind ``doNotEmitWarningStx | |
| -- `#eval` instead of `initialize` so that the effect can be tested in this file | |
| #eval Mathlib.Linter.UnusedTactic.addIgnoreTacticKind ``doNotEmitWarningStx |
is that right? Maybe worth adding a note because the docstring of addIgnoreTacticKind explicitely mentions initialize
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
Marks
isIgnoreTacticKindandaddIgnoreTacticKindin theunusedTacticlinter aspublicdefinitions.