Skip to content

feat(Tactic/Linter/UnusedTactic): mark isIgnoreTacticKind and addIgnoreTacticKind as public#41993

Open
eneoli wants to merge 2 commits into
leanprover-community:masterfrom
eneoli:eneoli/unused-tactic-public
Open

feat(Tactic/Linter/UnusedTactic): mark isIgnoreTacticKind and addIgnoreTacticKind as public#41993
eneoli wants to merge 2 commits into
leanprover-community:masterfrom
eneoli:eneoli/unused-tactic-public

Conversation

@eneoli

@eneoli eneoli commented Jul 21, 2026

Copy link
Copy Markdown

Marks isIgnoreTacticKind and addIgnoreTacticKind in the unusedTactic linter as public definitions.


Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 21, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the t-linter Linter label Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR summary 6bb1fd1237

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 6bb1fd1).

  • +2 new declarations
  • −0 removed declarations
+Mathlib.Linter.UnusedTactic.addIgnoreTacticKind
+Mathlib.Linter.UnusedTactic.isIgnoreTacticKind

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 6bb1fd1237
Reference commit a6b233c22a

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@eneoli eneoli changed the title UnusedTactic: mark isIgnoreTacticKind and addIgnoreTacticKind as public feat(Tactic/Linter/UnusedTactic): mark isIgnoreTacticKind and addIgnoreTacticKind as public Jul 21, 2026

@joneugster joneugster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I've been a bit confused at first, so I've added an optional suggestion for a comment about the thing I've been confused about.

maintainer merge

macro_rules
| `(command| doNotEmitWarning $tac) => `(command| example : True := by $tac ; constructor)

#eval Mathlib.Linter.UnusedTactic.addIgnoreTacticKind ``doNotEmitWarningStx

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#eval Mathlib.Linter.UnusedTactic.addIgnoreTacticKind ``doNotEmitWarningStx
-- `#eval` instead of `initialize` so that the effect can be tested in this file
#eval Mathlib.Linter.UnusedTactic.addIgnoreTacticKind ``doNotEmitWarningStx

is that right? Maybe worth adding a note because the docstring of addIgnoreTacticKind explicitely mentions initialize

@joneugster joneugster self-assigned this Jul 24, 2026
@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by joneugster.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-linter Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants