[Merged by Bors] - fix: update scripts/rm_set_option.py to ignore more comments#41997
Closed
vlad902 wants to merge 2 commits into
Closed
[Merged by Bors] - fix: update scripts/rm_set_option.py to ignore more comments#41997vlad902 wants to merge 2 commits into
scripts/rm_set_option.py to ignore more comments#41997vlad902 wants to merge 2 commits into
Conversation
Currently `scripts/rm_set_option.py` will ignore any lines that look like `set_option ... in -- COMMENT`; however, the 4.33.0-rc1 bump introduced many `set_option`s that were unsafe to delete as indicated by a preceding `#adaptation_note`/comment. This PR updates cript to now ignores `--` and `/-- ... -/` comments before a set_option. This includes catching `#adaptation_note`s Related [Zulip thread](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/4.2E33.2E0-rc1.20Multiple.20.60respectTransparency.60-related.20issues/near/611128727) :robot: Prepared with Claude
PR summary 18e5b7b0fdImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Contributor
|
Thanks! |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
Currently `scripts/rm_set_option.py` will ignore any lines that look like `set_option ... in -- COMMENT`; however, the 4.33.0-rc1 bump introduced many `set_option`s that were unsafe to delete as indicated by a preceding `#adaptation_note`/comment. This PR updates the script to ignore `--` and `/-- ... -/` comments before a set_option. This includes catching `#adaptation_note`s Related [Zulip thread](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/4.2E33.2E0-rc1.20Multiple.20.60respectTransparency.60-related.20issues/near/611128727) :robot: Prepared with Claude
Contributor
|
Pull request successfully merged into master. Build succeeded: |
scripts/rm_set_option.py to ignore more commentsscripts/rm_set_option.py to ignore more comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
scripts/rm_set_option.pywill ignore any lines that look likeset_option ... in -- COMMENT; however, the 4.33.0-rc1 bump introduced manyset_options that were unsafe to delete as indicated by a preceding#adaptation_note/comment.This PR updates the script to ignore
--and/-- ... -/comments before a set_option. This includes catching#adaptation_notesRelated Zulip thread
🤖 Prepared with Claude