Skip to content

[Merged by Bors] - chore(CategoryTheory): make Under implicit_reducible#41998

Closed
YaelDillies wants to merge 1 commit into
leanprover-community:masterfrom
YaelDillies:under_implicit_reducible
Closed

[Merged by Bors] - chore(CategoryTheory): make Under implicit_reducible#41998
YaelDillies wants to merge 1 commit into
leanprover-community:masterfrom
YaelDillies:under_implicit_reducible

Conversation

@YaelDillies

@YaelDillies YaelDillies commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This follows what's already done for Over. Demonstrate the progress by removing the set_option on AlgEquiv.toUnder.

From Toric


Open in Gitpod

This follows what's already done for `Over`. Demonstrate the progress by removing the `set_option` on `AlgEquiv.toUnder`.
@YaelDillies YaelDillies added t-category-theory Category theory toric Part of the ongoing formalisation of toric varieties labels Jul 22, 2026
@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jul 22, 2026
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

PR summary 46c3bff601

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 46c3bff).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


Decrease in strong tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (strong)
4155 -1 backward.isDefEq.respectTransparency.types
No changes to weak technical debt.

Current commit 46c3bff601
Reference commit 2c973492e6

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@robin-carlier

Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 22, 2026
@joelriou

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 22, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 22, 2026
This follows what's already done for `Over`. Demonstrate the progress by removing the `set_option` on `AlgEquiv.toUnder`.

From Toric
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 22, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 22, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(CategoryTheory): make Under implicit_reducible [Merged by Bors] - chore(CategoryTheory): make Under implicit_reducible Jul 22, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 22, 2026
@YaelDillies
YaelDillies deleted the under_implicit_reducible branch July 22, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-category-theory Category theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip toric Part of the ongoing formalisation of toric varieties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants