chore(Archive): convert to the module system#42010
Conversation
PR summary 8180fd74a7Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (weak) |
|---|---|---|
| 5041 | 22 | exposed public sections |
Current commit 8180fd74a7
Reference commit c026161a58
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
felixpernegger
left a comment
There was a problem hiding this comment.
Great PR; Did you check if some of these imports can be private? Since Archive is never really imported anyways; this shouldnt matter too much, but still nice to have
I did not. Be my guest to do so in a follow-up PR. I don't think this needs to block merging this PR. |
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Mostly mechanical migration, akin to what
modulize.leanwould do: make all importspublic, and add@[expose] public sectionat the beginning of each file. (In a few cases of files without definitions, omit the expose attribute.)Inspired by #36236; re-done by hand. All files omitted there are actually fine to hand-convert.