Skip to content

[Merged by Bors] - chore: golf proofs of mdifferentiableAt_atlas{_symm}#42011

Closed
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:golf-mdiff-atlas-symm
Closed

[Merged by Bors] - chore: golf proofs of mdifferentiableAt_atlas{_symm}#42011
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:golf-mdiff-atlas-symm

Conversation

@grunweg

@grunweg grunweg commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
  • introduce mdifferentiableAt_of_mem_maximalAtlas and mdifferentiableAt_symm_of_mem_maximalAtlas; these generalise the corresponding results to members of the maximal atlas;
  • golf the proofs of these lemmas by re-using the corresponding results about maximal atlas members being C^n.

The second bullet slightly strenthens an import dependency (of this file on the corresponding C^n proofs): I consider this unproblematic since

  • that dependency was already implicit before,
  • there does not seem a pressing need to tease apart imports further; if such need arises, this proof can be reverted,
  • for feat: if f is an immersion at x, then x is an immersed point #41796 (the first half of "the composition of immersions is an immersion"), I need versions of these lemmas for extended charts (which are known to be in the maximal atlas). This is a neat way to obtain this.

Open in Gitpod

…eAt_atlas{_symm}

Introduce mdifferentiableAt_of_mem_maximalAtlas and
mdifferentiableAt_symm_of_mem_maximalAtlas which generalise these to
members of the maximal atlas, and
golf the proofs of these lemmas by re-using the corresponding results about
atlas members being C^n.

It is possible the original proofs were necessary back then; at this point,
there does not seems a pressing need to tease apart imports further.
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

PR summary 23143ef87d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ mdifferentiableAt_of_mem_maximalAtlas
+ mdifferentiableAt_symm_of_mem_maximalAtlas

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 23143ef).

  • +2 new declarations
  • −0 removed declarations
+mdifferentiableAt_of_mem_maximalAtlas
+mdifferentiableAt_symm_of_mem_maximalAtlas

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 23143ef87d
Reference commit c026161a58

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@fpvandoorn

Copy link
Copy Markdown
Member

LGTM

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 22, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 22, 2026
- introduce `mdifferentiableAt_of_mem_maximalAtlas` and `mdifferentiableAt_symm_of_mem_maximalAtlas`; these generalise the corresponding results to members of the maximal atlas;
- golf the proofs of these lemmas by re-using the corresponding results about maximal atlas members being C^n.

The second bullet slightly strenthens an import dependency (of this file on the corresponding `C^n` proofs): I consider this unproblematic since
- that dependency was already implicit before,
- there does not seem a pressing need to tease apart imports further; if such need arises, this proof can be reverted,
- for #41796 (the first half of "the composition of immersions is an immersion"), I need versions of these lemmas for extended charts (which are known to be in the maximal atlas). This is a neat way to obtain this.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 22, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore: golf proofs of mdifferentiableAt_atlas{_symm} [Merged by Bors] - chore: golf proofs of mdifferentiableAt_atlas{_symm} Jul 22, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 22, 2026
@grunweg
grunweg deleted the golf-mdiff-atlas-symm branch July 22, 2026 21:24
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Jul 22, 2026
Generalise `isInvertible_mfderiv_extChartAt` and its preliminary lemmas
to any extended chart in the maximal atlas: this will be used in leanprover-community#41796
to prove that immersions have immersed points.

----------

- [x] depends on: leanprover-community#42011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants