Skip to content

[Merged by Bors] - perf(Positivity): filter with isProp in compareHyp #42014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JovanGerb wants to merge 1 commit into from
+2 −0
Closed

[Merged by Bors] - perf(Positivity): filter with isProp in compareHyp #42014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Mathlib/Tactic/Positivity/Core.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ initialize registerTraceClass `Tactic.positivity.failure
where `a` is a numeral. -/
def compareHyp (pα : Q(PartialOrder $α)) (e : Q($α)) (ldecl : LocalDecl) :
MetaM (Strictness zα e pα) := do
unless ← isProp ldecl.type do return .none
have e' : Q(Prop) := ldecl.type
let p : Q($e') := .fvar ldecl.fvarId
match e' with
Expand Down Expand Up @@ -396,6 +397,7 @@ def compareHyp (pα : Q(PartialOrder $α)) (e : Q($α)) (ldecl : LocalDecl) :

/-- A variation on `assumption` when the hypothesis is `e ≠ 0` or `0 ≠ e`. -/
def compareHypNonzero {pα?} (e : Q($α)) (ldecl : LocalDecl) : MetaM (Strictness zα e pα?) := do
unless ← isProp ldecl.type do return .none
have e' : Q(Prop) := ldecl.type
let p : Q($e') := .fvar ldecl.fvarId
match e' with
Expand Down
Loading