feat: set pp.mvars.anonymous false for MathlibTest#42016
Open
thorimur wants to merge 4 commits into
Open
Conversation
pp.mvars.anonymous false for MathlibTestpp.mvars.anonymous false for MathlibTest
PR summary 34adf13417Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets
pp.mvars.anonymous falseforMathlibTestin the lakefile, and removes the now-superfluousset_options which did so in individual tests.In tests, we always want to set this option (which pretty-prints autogenerated mvars such as
?m.37as?_) to ensure that they are stable. Instead of looking for it during review, we can just have it always set to the correct value by default.In fact, this PR also catches some unstable tests which slipped past during review.
It also documents the decision to not use the standard mathlib options, and removes stale documentation around
mathlibLeanOptions. (Note:mathlibLeanOptionsimplicitly says that tests should use⟨`maxSynthPendingDepth, .ofNat 3⟩, but we've been getting by just fine without that.)So far this is the only option for
MathlibTest, but we may as well still put it in an array to hold the documentation and not interrupt the flow oflean_libs. (And maybe make it easier set other options for MathlibTest in the future if we find we need them.)I'm not sure whether this is a chore or a feat! Since it's a lakefile change I erred on the side of "feat".