Skip to content

[Merged by Bors] - feat(Algebra/Lie): use IsApply for Weight - #42129

Closed
mcdoll wants to merge 3 commits into
leanprover-community:masterfrom
mcdoll:IsApplyLie
Closed

[Merged by Bors] - feat(Algebra/Lie): use IsApply for Weight#42129
mcdoll wants to merge 3 commits into
leanprover-community:masterfrom
mcdoll:IsApplyLie

Conversation

@mcdoll

@mcdoll mcdoll commented Jul 27, 2026

Copy link
Copy Markdown
Member

Open in Gitpod

@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

PR summary 34c11e47bb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ instance [Nontrivial (genWeightSpace M (0 : L → R))] : IsZeroApply (Weight R L M) L R

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 34c11e4).

  • +1 new declarations
  • −0 removed declarations
+LieModule.Weight.instIsZeroApply

Decrease in strong tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (strong)
4140 -1 backward.isDefEq.respectTransparency.types
No changes to weak technical debt.

Current commit 34c11e47bb
Reference commit 671e5520a2

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 27, 2026

@grunweg grunweg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer delegate

Comment thread Mathlib/Algebra/Lie/Weights/Basic.lean
@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 27, 2026
@mcdoll

mcdoll commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

since this one has a FunLike.coe_zero in it, it would be good to have David Loeffler's PR in first (maintainer merged by me), then this one gets a bit streamlined.

@ocfnash

ocfnash commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 28, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 28, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 28, 2026
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 28, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title feat(Algebra/Lie): use IsApply for Weight [Merged by Bors] - feat(Algebra/Lie): use IsApply for Weight Jul 28, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants