Skip to content

[Merged by Bors] - fix(RepresentationTheory): move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests - #43047

Closed
JX-Mo wants to merge 1 commit into
leanprover-community:masterfrom
JX-Mo:Equiv.coe_invFun
Closed

[Merged by Bors] - fix(RepresentationTheory): move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests#43047
JX-Mo wants to merge 1 commit into
leanprover-community:masterfrom
JX-Mo:Equiv.coe_invFun

Conversation

@JX-Mo

@JX-Mo JX-Mo commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

The current statement of lemma coe_invFun : φ.invFun = φ.symm := rfl actually reads φ.symm as⇑φ.toLinearEquiv.symm. However the context tends to make Representation.Equiv as the simp normal form, not φ.toLinearEquiv. We move it to where Representation.Equiv.symm has been defined so that the RHS has the correct form to get access to other API lemmas more directly.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Aug 22, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@JX-Mo

JX-Mo commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

easy

@github-actions github-actions Bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 22, 2026
@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown

PR summary e42dff0012

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit e42dff0).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit e42dff0012
Reference commit b4a18d6453

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Aug 22, 2026
@JX-Mo JX-Mo changed the title fix(RepresentationTheory) : move the to the correct .symm notion to fit the statement as it suggests fix(RepresentationTheory) : move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests Aug 22, 2026
@JX-Mo JX-Mo changed the title fix(RepresentationTheory) : move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests fix(RepresentationTheory) : move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests Aug 22, 2026
@JX-Mo JX-Mo changed the title fix(RepresentationTheory) : move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests fix(RepresentationTheory): move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests Aug 22, 2026

@Whysoserioushah Whysoserioushah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jjdishere

Copy link
Copy Markdown
Collaborator

Thanks,

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by jjdishere.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 24, 2026
@kbuzzard

Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 25, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 25, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
…m notion to fit the statement as it suggests (#43047)

The current statement of `lemma coe_invFun : φ.invFun = φ.symm := rfl` actually reads `φ.symm` as`⇑φ.toLinearEquiv.symm`. However the context tends to make `Representation.Equiv` as the simp normal form, not `φ.toLinearEquiv`. We move it to where `Representation.Equiv.symm` has been defined so that the RHS has the correct form to get access to other API lemmas more directly.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 25, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title fix(RepresentationTheory): move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests [Merged by Bors] - fix(RepresentationTheory): move Equiv.coe_invFun to the correct symm notion to fit the statement as it suggests Aug 25, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants