Skip to content

chore(Data/PFunctor): fix defeq abuse in PFunctor.Obj - #43056

Open
plp127 wants to merge 9 commits into
leanprover-community:masterfrom
plp127:aliu/PFunctor-Obj
Open

chore(Data/PFunctor): fix defeq abuse in PFunctor.Obj#43056
plp127 wants to merge 9 commits into
leanprover-community:masterfrom
plp127:aliu/PFunctor-Obj

Conversation

@plp127

@plp127 plp127 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Fix defeq abuse with PFunctor.Obj by using explicit constructors and destructors.


Open in Gitpod

@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Aug 23, 2026
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

PR summary 5c64610700

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Comp.mk_run
+ Comp.run_mk
+ Obj.eta
+ Obj.fst
+ Obj.fst_mk
+ Obj.mk
+ Obj.rec
+ Obj.rec_mk
+ Obj.snd
+ Obj.snd_mk

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 5c64610).

  • +10 new declarations
  • −0 removed declarations
+Functor.Comp.mk_run
+Functor.Comp.run_mk
+PFunctor.Obj.eta
+PFunctor.Obj.fst
+PFunctor.Obj.fst_mk
+PFunctor.Obj.mk
+PFunctor.Obj.rec
+PFunctor.Obj.rec_mk
+PFunctor.Obj.snd
+PFunctor.Obj.snd_mk

Decrease in strong tech debt: (relative, absolute) = (12.00, 0.00)
Current number Change Type (strong)
backward.isDefEq.respectTransparency 4915 -12
No changes to weak technical debt.

Current commit 5c64610700
Reference commit b63493a474

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-data Data (lists, quotients, numbers, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant