Skip to content

[Merged by Bors] - chore(Algebra/Ring/Invertible): golf a proof using grind - #43060

Closed
yuanyi-350 wants to merge 1 commit into
leanprover-community:masterfrom
yuanyi-350:chore/invertible-grind
Closed

[Merged by Bors] - chore(Algebra/Ring/Invertible): golf a proof using grind#43060
yuanyi-350 wants to merge 1 commit into
leanprover-community:masterfrom
yuanyi-350:chore/invertible-grind

Conversation

@yuanyi-350

@yuanyi-350 yuanyi-350 commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Trace profiling results:

neg_one_eq_invOf_mul_add_invOf_mul_iff: 50 ms before, <12 ms after 🎉
Profiled using set_option trace.profiler true in.

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

PR summary c14b4ac5be

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- unavailable)

⚠️ No declarations diff yet: there is no built master snapshot at this PR's merge-base (typically a bors-batch intermediate that CI never built). Merge master into this PR and push to refresh.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit c14b4ac5be
Reference commit ca0ba44e15

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Aug 23, 2026
@yuanyi-350 yuanyi-350 added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 23, 2026
@Whysoserioushah

Copy link
Copy Markdown
Collaborator

!radar

@leanprover-radar

leanprover-radar commented Aug 23, 2026

Copy link
Copy Markdown

Benchmark results for c14b4ac against ca0ba44 are in. No significant results found. @Whysoserioushah

  • 🟥 build//instructions: +335.5M (+0.00%)

Small changes (1✅)

  • build/module/Mathlib.AlgebraicGeometry.Sites.ElladicCohomology//instructions: -680.0M (-0.52%)

@Whysoserioushah Whysoserioushah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general slowdown should just be noise, LGTM!

@themathqueen themathqueen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 23, 2026
@yuanyi-350
yuanyi-350 requested a review from grunweg August 24, 2026 09:04

@grunweg grunweg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 24, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 24, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 24, 2026
Trace profiling results:

`neg_one_eq_invOf_mul_add_invOf_mul_iff`: 50 ms before, <12 ms after 🎉
Profiled using `set_option trace.profiler true in`.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 24, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(Algebra/Ring/Invertible): golf a proof using grind [Merged by Bors] - chore(Algebra/Ring/Invertible): golf a proof using grind Aug 24, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 24, 2026
@yuanyi-350
yuanyi-350 deleted the chore/invertible-grind branch August 27, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants