[Merged by Bors] - chore: standardise names for coercions from morphism classes to morphisms - #43367
[Merged by Bors] - chore: standardise names for coercions from morphism classes to morphisms#43367grunweg wants to merge 9 commits into
Conversation
PR summary 6947e22e01Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by mcdoll. |
|
This pull request has conflicts, please merge |
|
bors d+ Looks great, thanks for splitting into a bitesize piece! |
|
✌️ grunweg can now approve this pull request until 2026-09-21 07:03 UTC (in 2 weeks). To approve and merge, reply with
|
|
As this PR is labelled bors merge |
…isms (#43367) Following item (2) in #31365, the definition which implements the coercion from a morphism class `FooHomClass` to `FooHoms` should be called `FooHom.ofClass`. - the name is easy to remember and guess - it matches the existing names we have for the corresponding declarations for subobjects - when Lean expects a `FooHom`, you can write `.ofClass f`. Make five more morphism classes follow this pattern.
|
Build failed (retrying...): |
…isms (#43367) Following item (2) in #31365, the definition which implements the coercion from a morphism class `FooHomClass` to `FooHoms` should be called `FooHom.ofClass`. - the name is easy to remember and guess - it matches the existing names we have for the corresponding declarations for subobjects - when Lean expects a `FooHom`, you can write `.ofClass f`. Make five more morphism classes follow this pattern.
|
Pull request successfully merged into master. Build succeeded: |
Following item (2) in #31365, the definition which implements the coercion from a morphism class
FooHomClasstoFooHomsshould be calledFooHom.ofClass.FooHom, you can write.ofClass f.Make five more morphism classes follow this pattern.