perf(Tactic/Positivity): run extensions in reducible transparency - #43504
Open
JovanGerb wants to merge 7 commits into
Open
perf(Tactic/Positivity): run extensions in reducible transparency#43504JovanGerb wants to merge 7 commits into
reducible transparency#43504JovanGerb wants to merge 7 commits into
Conversation
PR summary 53072a60b9Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
Author
|
!radar |
|
Benchmark results for 53072a6 against 80cbd04 are in. There are significant results. @JovanGerb
Large changes (1✅)
Medium changes (2✅)
Small changes (5✅, 1🟥)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so that
positivityextensions are executed atreducibletransparency, which should help with proof maintainability, and gives a slight speedup.0 i < xis still considered a positivity goal, even though0 iis not defeq to0at reducible transparency.isDefEq, so this has to be done at theimplicittransparency. Apparently, this change causespositivityto succeed somewhere where it did not before.