Skip to content

chore(Topology/CantorBendixson): cleanup + more basic API - #43526

Open
vihdzp wants to merge 1 commit into
leanprover-community:masterfrom
vihdzp:cbx
Open

chore(Topology/CantorBendixson): cleanup + more basic API#43526
vihdzp wants to merge 1 commit into
leanprover-community:masterfrom
vihdzp:cbx

Conversation

@vihdzp

@vihdzp vihdzp commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

We perform various small golfs, make some variables explicit, and add a few trivial lemmas.


I would've suggested all of this in #37375, but somehow that PR went under my radar.

Open in Gitpod

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR summary 5ab0ff5144

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ gfpApprox_def
+ iteratedDerivSet_of_ne_zero
+ iteratedDerivedSet_add_one
+ iteratedDerivedSet_def
+ iteratedDerivedSet_monotone
+ lfpApprox_def

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 5ab0ff5).

  • +6 new declarations
  • −0 removed declarations
+CantorBendixson.iteratedDerivSet_of_ne_zero
+CantorBendixson.iteratedDerivedSet_add_one
+CantorBendixson.iteratedDerivedSet_def
+CantorBendixson.iteratedDerivedSet_monotone
+OrdinalApprox.gfpApprox_def
+OrdinalApprox.lfpApprox_def

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 5ab0ff5144
Reference commit e3ea2ac394

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp vihdzp added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant