feat: add assignments to tuples and lists #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govereau
commented
Jan 21, 2025
| | .expr e _ => add_stmt (.expr e) | ||
| | _ => return () -- effects are done, can be removed from KLR | ||
| let t <- term e | ||
| let _ <- RValue t |
There was a problem hiding this comment.
I am not sure if this is clear. But my thinking is that if you have an expression as a statement, then we can use the RValue conversion to figure out if it "has side-effects". If it does, the RValue translation will insert an assignment to a fresh variable, otherwise we just discard the expression (e.g. doc strings, etc.)
seanmcl
approved these changes
Jan 21, 2025
|
|
||
| -- Top-level assignment handling | ||
| -- e.g. x1 = x2 = e | ||
| def assign (xs : List Term) (e : Term) : Tracer Unit := do |
govereau
force-pushed
the
pg-pretty
branch
2 times, most recently
from
00e1cbb to
b94f357
Compare
This change adds support for assignment like: `x, y = z`. Python calls this "unpacking", and you can convert between lists and tuples as long as they are the right length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for assignment like:
x, y = z. Python calls this "unpacking", and you can convert between lists and tuples as long as they are the right length.