-
Notifications
You must be signed in to change notification settings - Fork 688
feat: add Std.Trichotomous
#10945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add Std.Trichotomous
#10945
Conversation
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
|
!bench |
|
Benchmark results for 6cc5bd3 against e71d0ab are in! @datokrat |
|
Here are the benchmark results for commit 6cc5bd3. Benchmark Metric Change
================================================================
- iterators (compiled) wall-clock 5.6% (39.7 σ)
- stdlib grind dsimp 5.3% (25.5 σ)
- stdlib process pre-definitions 1.3% (24.3 σ)
- stdlib task-clock 1.0% (40.2 σ) |
|
I will address your comments when I can (I have some work things which may take a little time). Bit worried about the performance hit here but maybe restoring those instances will fix that. |
|
Yes, I find it quite amazing how hard it can be to predict the performance impact of small changes to the typeclass hierarchy. In this case, I'm especially confused by the Radar (our new speedcenter that is still under development) luckily confirms that at least the specific |
|
Note: I slightly edited the PR description to match our changelog convention (removing the |
|
Other than that one question about restoring instances (where I am concerned that taking a divergent approach with Total/Asymm and Antisymm/Trichotomous could lead to confusion down the line) I have acted on your comments, so (accepting that we still have that one question to resolve) I am going to pass this back. |
|
Right - apologies for the delay. This is ready for review again I believe. |
No problem at all (and my review was also a bit delayed). |
|
Right, should be all done. |
Std.TrichotomousStd.Trichotomous
Std.TrichotomousStd.Trichotomous
Std.TrichotomousStd.Trichotomous
|
awaiting-review |
This PR adds
Std.Tricho r, a typeclass for relations which identifies them as trichotomous. This is preferred toStd.Antisymm (¬ r · ·)in all cases (which it is equivalent to).